Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scaling input features to attacks #2384

Merged
merged 11 commits into from
Apr 4, 2024

Conversation

abigailgold
Copy link
Collaborator

Description

Both black-box membership inference and black-box attribute inference can scale input features to the attack using multiple options of sciki-learn scalers (default is StandardScaler).

Fixes #2152

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

New tests that try out all options for scaling.

Test Configuration:

  • OS: MacOS 14.2.1
  • Python version: 3.9
  • ART version or commit number
  • TensorFlow / Keras / PyTorch / MXNet version

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes have been tested using both CPU and GPU devices

Signed-off-by: abigailt <abigailt@il.ibm.com>
Signed-off-by: abigailt <abigailt@il.ibm.com>
Signed-off-by: abigailt <abigailt@il.ibm.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2024

Codecov Report

Attention: Patch coverage is 78.84615% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 85.52%. Comparing base (3597228) to head (290519d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           dev_1.18.0    #2384      +/-   ##
==============================================
- Coverage       85.54%   85.52%   -0.02%     
==============================================
  Files             327      327              
  Lines           29888    29937      +49     
  Branches         5528     5546      +18     
==============================================
+ Hits            25567    25604      +37     
- Misses           2900     2905       +5     
- Partials         1421     1428       +7     
Files Coverage Δ
...attacks/inference/attribute_inference/black_box.py 89.62% <87.50%> (-0.14%) ⬇️
...ttacks/inference/membership_inference/black_box.py 88.71% <75.00%> (-1.79%) ⬇️

... and 3 files with indirect coverage changes

@beat-buesser beat-buesser self-requested a review January 15, 2024 13:20
@beat-buesser beat-buesser self-assigned this Jan 15, 2024
@beat-buesser beat-buesser added this to the ART 1.18.0 milestone Jan 15, 2024
dependabot bot and others added 7 commits January 17, 2024 08:30
Updates the requirements on [scikit-learn](https://github.com/scikit-learn/scikit-learn) to permit the latest version.
- [Release notes](https://github.com/scikit-learn/scikit-learn/releases)
- [Commits](scikit-learn/scikit-learn@0.22.2...1.3.2)

---
updated-dependencies:
- dependency-name: scikit-learn
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Beat Buesser <beat.buesser@ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ibm.com>
Copy link
Collaborator

@beat-buesser beat-buesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abigailgold Thank you very much! It looks good to me.

@beat-buesser beat-buesser merged commit 31fafff into Trusted-AI:dev_1.18.0 Apr 4, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Pull request done
Development

Successfully merging this pull request may close these issues.

3 participants