Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable lists in patch_shape of DPatch #662

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Conversation

beat-buesser
Copy link
Collaborator

Signed-off-by: Beat Buesser beat.buesser@ie.ibm.com

Description

This pull request enables lists in patch_shape of DPatch.

Fixes #661

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Sorry, something went wrong.

Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@beat-buesser beat-buesser self-assigned this Oct 14, 2020
@beat-buesser beat-buesser added the improvement Improve implementation label Oct 14, 2020
@beat-buesser beat-buesser added this to the ART 1.4.2 milestone Oct 14, 2020
@beat-buesser beat-buesser linked an issue Oct 14, 2020 that may be closed by this pull request
@beat-buesser beat-buesser force-pushed the development_issue_661 branch from 7e79dfe to 863b192 Compare October 14, 2020 21:27
@codecov-io
Copy link

codecov-io commented Oct 14, 2020

Codecov Report

Merging #662 into dev_1.4.2 will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           dev_1.4.2     #662   +/-   ##
==========================================
  Coverage      58.97%   58.97%           
==========================================
  Files            155      155           
  Lines          14197    14197           
  Branches        2549     2549           
==========================================
  Hits            8373     8373           
  Misses          5022     5022           
  Partials         802      802           
Impacted Files Coverage Δ
art/attacks/evasion/dpatch.py 15.60% <0.00%> (ø)

Copy link
Collaborator

@lcadalzo lcadalzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beat-buesser beat-buesser merged commit a3b93f5 into dev_1.4.2 Oct 15, 2020
@beat-buesser beat-buesser deleted the development_issue_661 branch October 15, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable passing a list for DPatch's patch_shape
3 participants