Fix #728: PyTorchDataGenerator always returns the same batch #731
+16
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to ART 1.4.2
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Bumps [statsmodels](https://github.com/statsmodels/statsmodels) from 0.12.0 to 0.12.1. - [Release notes](https://github.com/statsmodels/statsmodels/releases) - [Changelog](https://github.com/statsmodels/statsmodels/blob/master/CHANGES.md) - [Commits](statsmodels/statsmodels@v0.12.0...v0.12.1) Signed-off-by: dependabot[bot] <support@github.com>
…smodels-0.12.1 Bump statsmodels from 0.12.0 to 0.12.1
IBM to Trusted-AI
… same batch Signed-off-by: hornel <hornel@ethz.ch>
beat-buesser
added
improvement
beat-buesser
approved these changes
Nov 11, 2020
|
@hornel Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hornel hornel@ethz.ch
Description
Fixes
art.data_generators.PyTorchDataGeneratorandart.data_generators.MXDataGenerator. Previously, they always returned the same batch (assuming the underlying DataLoader had shuffle disabled), whereas they now properly iterate through the underlying DataLoader.Fixes #728. I also noticed the same issue with MXDataGenerator and provided the same fix.
Type of change
Please check all relevant options.
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
tests/test_data_generators/TestPyTorchGeneratortests/test_data_generators/TestMXGeneratorTest Configuration:
Checklist