Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Boundary Attack #761

Merged
merged 5 commits into from
Nov 26, 2020
Merged

Updates for Boundary Attack #761

merged 5 commits into from
Nov 26, 2020

Conversation

beat-buesser
Copy link
Collaborator

@beat-buesser beat-buesser commented Nov 25, 2020

Signed-off-by: Beat Buesser beat.buesser@ie.ibm.com

Description

This pull request provides updates for BoundaryAttack to make it consistent with the reference implementation and support all input shapes. The updated BoundaryAttack calculates perturbation and direction on the entire input instead of per channel and applies the correct inner product calculation resulting in faster convergence.

Thank you to Michael Craig and Manish Bhardwaj for sharing this update.

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Sorry, something went wrong.

Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@beat-buesser beat-buesser self-assigned this Nov 25, 2020
@beat-buesser beat-buesser added the improvement Improve implementation label Nov 25, 2020
@beat-buesser beat-buesser added this to the ART v1.5.0 milestone Nov 25, 2020
@beat-buesser beat-buesser changed the title Updates for Boundary attack Updates for Boundary Attack Nov 25, 2020

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Collaborator

@minhitbk minhitbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beat-buesser The code looks good, I just have a few minor suggestions.

beat-buesser and others added 3 commits November 26, 2020 16:59

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: minhitbk <minhitbk@gmail.com>

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: minhitbk <minhitbk@gmail.com>

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
@beat-buesser beat-buesser merged commit 1195bc1 into dev_1.5.0 Nov 26, 2020
@beat-buesser beat-buesser deleted the development_boundary branch November 26, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants