-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset adaptive optimizers per batch in ASR attack #917
Conversation
Codecov Report
@@ Coverage Diff @@
## dev_1.5.3 #917 +/- ##
==============================================
- Coverage 64.93% 40.34% -24.60%
==============================================
Files 176 201 +25
Lines 17223 17879 +656
Branches 3191 3277 +86
==============================================
- Hits 11184 7213 -3971
- Misses 4771 9857 +5086
+ Partials 1268 809 -459
|
art/attacks/evasion/imperceptible_asr/imperceptible_asr_pytorch.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hesseltuinhof Thank you very much the updates. I have one proposal, what do you think?
Signed-off-by: Hessel Tuinhof <hessel.tuinhof@ibm.com>
a8f265d
to
6a70eac
Compare
Thanks @beat-buesser. That was a really good spot of yours, which slipped in at the end when I made those two attributes private 😃 I updated the PR accordingly! |
Hi @hesseltuinhof Thank you very much, these are great improvements! The tests TensorFlow 2.4.1v1 and TensorFlow+Lingvo 2.1.0v1 have not run because we changed settings in the repo when the PR was created. I have run them localyl and they are passing. |
Description
Fixes #910
Type of change
Please check all relevant options.
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
Test Configuration:
Checklist