Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing error when launching Alex without private configs. #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ticcky
Copy link
Contributor

@ticcky ticcky commented Feb 1, 2015

Adding an empty file that will prevent Alex from failing because of including private files from the main config that do not exist in case somebody is using Alex without the private repository.

@oplatek
Copy link
Member

oplatek commented Feb 2, 2015

@ticcky what will happen if you want to add the private git repository?
Will it mess the git index with the real secret default.cfg?
If yes, this is easy way how to expose the secret private/default.cfg by accidentally committing it to the public UFAL-DSG/alex repository

@ticcky
Copy link
Contributor Author

ticcky commented Feb 2, 2015

That's right Ondra. Thanks! I think the best thing would be actually to remove the include from the config file altogether, and actually have the include in the secret file but in reverse. What do you think?

@oplatek
Copy link
Member

oplatek commented Feb 2, 2015

Well, is it really necessary to include one into another or vise versa?
Why not to load the "secret" values explicitly by specifying the "private/default.cfg" in the command line arguments by "-c private/default.cfg"?

@ticcky
Copy link
Contributor Author

ticcky commented Feb 2, 2015

That is even better. I will discuss it with Filip.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling ee7dc16 on UFAL-DSG:lz_private_config_fix into 0338af6 on UFAL-DSG:lz_private_config_fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants