Fix step rate bug (especially for retraction) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…greater than nominal speed - as seen with fast extrude/retract moves.
|
Looks simple, and your explanation is great. I will test this next week and merge it if I do not find any problems. This seems to be vital for dual-extrusion, as retraction was causing a lot of headache for us their. |
|
That is the correct fix. |
daid
added a commit
that referenced
this pull request
Mar 15, 2013
Fix step rate bug (especially for retraction)
|
ErikZalm@92782f9 done |
daid
added a commit
that referenced
this pull request
Mar 15, 2013
Fix step rate bug (especially for retraction)
hugokernel
pushed a commit
to hugokernel/Marlin
that referenced
this pull request
Nov 4, 2013
Marlin v1 ultimaker rc3
hugokernel
pushed a commit
to hugokernel/Marlin
that referenced
this pull request
Nov 4, 2013
fix max endstop pins
hugokernel
pushed a commit
to hugokernel/Marlin
that referenced
this pull request
Nov 4, 2013
Fix step rate bug (especially for retraction)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for the issue discussed here:
http://umforum.ultimaker.com/index.php?/topic/1734-marlin-bug-the-myth-of-retraction-speed/
It mostly affects fast retraction moves, but could affect any axis with the right combination of speeds and accelerations.
(This is my first github pull request... let me know if I'm not doing it right...)