Merge pull request #281 from UrbanAnalyst/news

update news for #278
UrbanAnalyst · Mar 10, 2025 · a104234 · a104234
2 parents 3566ff9 + cf6356a
commit a104234
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 8 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -5,7 +5,7 @@ repos:
     rev: v0.4.3
     hooks:
     -   id: style-files
-        args: [--style_pkg=spaceout, --style_fun=spaceout_style]    
+        args: [--style_pkg=spaceout, --style_fun=spaceout_style, --include_roxygen_examples=FALSE]    
         additional_dependencies:
         - ropensci-review-tools/spaceout
       # -   id: roxygenize

diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: dodgr
 Title: Distances on Directed Graphs
-Version: 0.4.2.001
+Version: 0.4.2.004
 Authors@R: c(
     person("Mark", "Padgham", , "mark.padgham@email.com", role = c("aut", "cre")),
     person("Andreas", "Petutschnig", role = "aut"),

diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,9 @@
 # v 0.4.2.00x (dev version)
 
+## Minor changes
+
+- Fix updating of edge times in `insert_one_edge`; #278 thanks to @leoniedu
+
 ---
 
 # v 0.4.2

diff --git a/R/graph-functions.R b/R/graph-functions.R
@@ -30,7 +30,7 @@ dodgr_graph_cols <- function (graph) {
         yto <- which (nms %in% c ("yto", "to_lat"))
         if (length (yto) == 0) yto <- NA
     } else {
-        edge_id <- find_edge_id_col(graph)
+        edge_id <- find_edge_id_col (graph)
 
         d_col <- find_d_col (graph)
         w_col <- find_w_col (graph)
@@ -503,11 +503,9 @@ insert_one_edge <- function (graph, index, x, y, gr_cols) {
     graph [index + 1, gr_cols$d_weighted] <- d2 * wt
 
     if (!is.na (gr_cols$time)) {
-        graph [index, gr_cols$time] <- d1 *
-            time_scale
+        graph [index, gr_cols$time] <- d1 * time_scale
         graph [index + 1, gr_cols$time] <- d2 * time_scale
-        graph [index, gr_cols$time_weighted] <-
-            d1 * time_scale * time_wt
+        graph [index, gr_cols$time_weighted] <- d1 * time_scale * time_wt
         graph [index + 1, gr_cols$time_weighted] <- d2 * time_scale * time_wt
     }
 

diff --git a/codemeta.json b/codemeta.json
@@ -11,7 +11,7 @@
   "codeRepository": "https://github.com/UrbanAnalyst/dodgr",
   "issueTracker": "https://github.com/UrbanAnalyst/dodgr/issues",
   "license": "https://spdx.org/licenses/GPL-3.0",
-  "version": "0.4.2.001",
+  "version": "0.4.2.004",
   "programmingLanguage": {
     "@type": "ComputerLanguage",
     "name": "R",