Add optional new api routes #504
Conversation
addons/godot_uro/godot_uro.gd
Outdated
| @@ -12,6 +12,7 @@ const http_pool_const = preload("./http_pool.gd") | |||
| # renewal_token and access_token have moved to GodotUroData. | |||
| var cfg: ConfigFile = null | |||
|
|
|||
| var new_api: bool = false | |||
There was a problem hiding this comment.
| var new_api: bool = false | |
| var new_api: bool = false |
Can you try a variable that is more unique so we know what it is a few years from now?
There was a problem hiding this comment.
Ok, but do we plan to keep this toggle that much?
There was a problem hiding this comment.
changed to 'use_dev_api'
There was a problem hiding this comment.
this is a problem when we use_dev_api_2?
There was a problem hiding this comment.
My idea was to have a permanent, non-versioned flag that enables "in-progress, not-deployed" features that will be merged as default api soon.
you want to imply a version instead, right?
There was a problem hiding this comment.
we could use use_api_v1_1
There was a problem hiding this comment.
I was thinking a specific permanent flag for each feature, that enables "in-progress, not-deployed" features that will be merged as default api soon.
So like English words without versions but meaning something. I'd accept codewords too.
There was a problem hiding this comment.
github-actions
bot
force-pushed
the
api-fix
branch
from
69bbb6c to
907b81b
Compare
|
After some discussion we decided to postpone api breaking changes, so I'm closing this PR. |
Adds 'use_dev_api' toggle in Project Settings to test new uro server