Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: rearrange packages, add libblockdev-crypto3 #21

Merged
merged 4 commits into from
Nov 27, 2023
Merged

cleanup: rearrange packages, add libblockdev-crypto3 #21

merged 4 commits into from
Nov 27, 2023

Conversation

kbdharun
Copy link
Member

@kbdharun kbdharun commented Nov 27, 2023 •
edited
Loading

Changes

  • Rearrange packages in alphabetical order.
  • Add libblockdev-crypto3 to libs-extra for LUKS (decryption) as suggested by @axtloss.
  • Move optipng from the desktop base to the utilities module. (Edit. Reverted this change after failing CI, seems like we use it to optimize first setup assets)
  • Remove inkscape from the desktop base as suggested by @taukakao.

@kbdharun
cleanup: rearrange pkgs, add libblockdev-crypto2
aac0f51 
Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@kbdharun
fix: move back optipng to desktop base module
0e96991 
Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@kbdharun
fix: libblockdev-crypto version
9c1a4d5 
Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@kbdharun kbdharun changed the title cleanup: rearrange packages, add libblockdev-crypto2 cleanup: rearrange packages, add libblockdev-crypto3 Nov 27, 2023
@kbdharun kbdharun requested a review from matbme November 27, 2023 10:38
axtloss
axtloss reviewed Nov 27, 2023
View reviewed changes
Copy link
Member

@axtloss axtloss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also explicitly install xdg-desktop-portal and xdg-desktop-portal-gtk instead of relying on them being pulled in as dependencies?

@matbme
Copy link
Member

matbme commented Nov 27, 2023

Maybe we should also explicitly install xdg-desktop-portal and xdg-desktop-portal-gtk instead of relying on them being pulled in as dependencies?

Shouldn't it be xdg-desktop-portal-gnome? I always forget which one should be used

@kbdharun
Copy link
Member Author

Maybe we should also explicitly install xdg-desktop-portal and xdg-desktop-portal-gtk instead of relying on them being pulled in as dependencies?

Shouldn't it be xdg-desktop-portal-gnome? I always forget which one should be used

Don't we already have it 🤔?

I will check the modules again to see if it's absent.

@axtloss
Copy link
Member

axtloss commented Nov 27, 2023

Maybe we should also explicitly install xdg-desktop-portal and xdg-desktop-portal-gtk instead of relying on them being pulled in as dependencies?

Shouldn't it be xdg-desktop-portal-gnome? I always forget which one should be used

xdg-desktop-portal-gnome is the gnome exclusive one, xdg-desktop-portal and xdg-desktop-portal-gtk are also required and are already pulled in by other packages, which in my opinion we should not rely on.

@kbdharun kbdharun requested a review from axtloss November 27, 2023 16:00
@kbdharun kbdharun merged commit f3fea2b into main Nov 27, 2023
@kbdharun kbdharun deleted the cleanup/update-deps branch November 27, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbme matbme matbme approved these changes

@axtloss axtloss axtloss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbdharun @matbme @axtloss