Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing buttons for video #15

Closed
Yago opened this issue Jun 23, 2015 · 9 comments
Closed

Sharing buttons for video #15

Yago opened this issue Jun 23, 2015 · 9 comments

Comments

@Yago
Copy link
Contributor

Yago commented Jun 23, 2015

@lcherpit Instead of adding custom PHP/JavaScript code to share those videos, why don't we use the native Youtube sharing system. To do that, we just have to remove the showinfo=0 parameter from the embed url. What do you think ?

sharing-video3

ping @ludovicrenevey

@lcherpit
Copy link
Contributor

Yep. make sense.

@lcherpit
Copy link
Contributor

done! fixed.

@tonifisler
Copy link
Contributor

La Vaudoise wants to be able to share the video from something else than Youtube (Montreux Jazz restrictions)

So you'll need to add the correct Open Graphs so that we can share the video only. We've added Addthis above the video too.

@tonifisler tonifisler reopened this Jul 8, 2015
@tonifisler
Copy link
Contributor

ping @lcherpit sorry ;)

tonifisler added a commit that referenced this issue Jul 8, 2015
@lcherpit
Copy link
Contributor

Hi @tonifisler,
Sry for the delay. Thanks for these changes.
we talked about this with Ludovic. ATM we're expecting some feedback about contractual agreement from the project owner and the PM to go ahead, plan these changes and resuming the project

@tonifisler
Copy link
Contributor

Fine for us! Let us know when you've got the green light.

@lcherpit
Copy link
Contributor

Addthis seems to not correctly work on firefox.
on the video page :
http://vaudoiseontour.ch/de/video/2015-way2rio-1/auf-dem-weg/
and neither with the last styleGuide [c9fb6c7]
http://localhost:3000/templates/video.html

@Yago
Copy link
Contributor Author

Yago commented Dec 18, 2015

Thanks for reporting that issue ! I have some trouble to reproduce it (see screenshot). I'm on Firefox 43 on Mac OSX 10.11.2 and you ?

capture d ecran 2015-12-18 a 08 21 44

@lcherpit
Copy link
Contributor

i've tested on OSX 10.11.2 firefox 42.0 and after the update to 43.0 and no extension installed the bug is still there.

Addthis throws this exception

e.ad.clr is not a function

video_vot Addthis exception

@Yago Yago closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants