Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] ListSecrets() and GetAllSecrets() returns only the first page #54

Closed
afirth opened this issue Oct 21, 2016 · 0 comments
Closed

[BUG] ListSecrets() and GetAllSecrets() returns only the first page #54

afirth opened this issue Oct 21, 2016 · 0 comments
Labels
bug

Comments

@afirth
Copy link

afirth commented Oct 21, 2016

If Table.scan would return more than 1MB, the result is paginated.
LastEvaluatedKey is set and scan() could be called again, or ScanPages could be used.
This bug appears to exist in credstash too

ListSecrets()
GetAllSecrets()
go docs
AWS docs
@wolfeidau wolfeidau added the bug label Oct 21, 2016
wolfeidau added a commit that referenced this issue Oct 23, 2016
@wolfeidau
Merge pull request #55 from athome-group/fix_list_and_getall_pagination
b9f4ab3 
Fix #54 ListSecrets() and GetAllSecrets() pagination
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wolfeidau @afirth