Skip to content

Commit

Permalink
refactor: Avoid escaping with sprintf if not needed
Browse files Browse the repository at this point in the history
Signed-off-by: Vincent Boutour <bob@vibioh.fr>
  • Loading branch information
ViBiOh committed Aug 14, 2024
1 parent 938b81a commit b40904d
Showing 1 changed file with 22 additions and 2 deletions.
24 changes: 22 additions & 2 deletions pkg/renderer/model.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,14 @@ func newMessage(key, level, format string, a ...any) Message {
}
}

func newRawMessage(key, level, format string) Message {
return Message{
Key: key,
Level: level,
Content: format,
}
}

func (m Message) String() string {
if len(m.Content) == 0 {
return ""
Expand All @@ -98,13 +106,25 @@ func ParseMessage(r *http.Request) Message {
}

func NewSuccessMessage(format string, a ...any) Message {
if len(a) == 0 {
return newRawMessage(defaultMessageKey, "success", format)
}

return newMessage(defaultMessageKey, "success", format, a...)
}

func NewErrorMessage(format string) Message {
return newMessage(defaultMessageKey, "error", format)
func NewErrorMessage(format string, a ...any) Message {
if len(a) == 0 {
return newRawMessage(defaultMessageKey, "error", format)
}

return newMessage(defaultMessageKey, "error", format, a...)
}

func NewKeyErrorMessage(key, format string, a ...any) Message {
if len(a) == 0 {
return newRawMessage(key, "error", format)
}

return newMessage(key, "error", format, a...)
}

0 comments on commit b40904d

Please sign in to comment.