Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: literature_fetch_recommendation_api.py stuck if sampling 10 negative articles is not possible #47

Closed
lilijap opened this issue Jul 25, 2024 · 5 comments
Closed

BUG: literature_fetch_recommendation_api.py stuck if sampling 10 negative articles is not possible #47

lilijap opened this issue Jul 25, 2024 · 5 comments
Assignees
@gurdeep330
Labels
bug Something isn't working released

Comments

@lilijap
Copy link
Contributor

lilijap commented Jul 25, 2024

Describe the bug
Script literature_fetch_recommendation_api.py is stuck, if sampling of negative papers is not possible (not enough papers in another "Topic" provided). It also does not produce an error or stops computations automatically.
See screen shot:
image

To Reproduce
Steps to reproduce the behavior:

  1. Use this .tsv file to run the literature_fetch_recommendation_api.py script locally in your lit. survey repo
    query.zip
  2. The script does not finish or give an error

Expected behavior

  • give an error that more papers should be provided
  • exit the code
  • OR not limit # of negative papers to 10 (use any number that is provided)
  • OR do not ask for negative papers, because some users just want to have 1 category.

Screenshots (optional)
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):
Win11

Additional context (optional)
Not limiting negative papers to 10 would increase the accessibility of this repo to unexperienced users.
@lilijap lilijap added the bug Something isn't working label Jul 25, 2024
@lilijap
Copy link
Contributor Author

lilijap commented Jul 25, 2024

Tagging @awmulyadi for your reference.

gurdeep330 added a commit to gurdeep330/literatureSurvey that referenced this issue Aug 8, 2024
@gurdeep330
fix: VirtualPatientEngine#47
7252026
@gurdeep330 gurdeep330 mentioned this issue Aug 8, 2024
Merged
22 tasks
awmulyadi added a commit that referenced this issue Aug 21, 2024
@awmulyadi
fix: changes on positive and negative articles, close #47
e46bfe3 
fix: changes on positive and negative articles due to Semantic Scholar Recommendation API restriction removal, close #47
@awmulyadi
Copy link
Contributor

This issue is fixed with PR #50

@lilijap lilijap closed this as completed Aug 22, 2024
@lilijap
Copy link
Contributor Author

lilijap commented Aug 22, 2024

@gurdeep330 and @awmulyadi thanks for your updates, I now closed this issue! 👍

gurdeep330 added a commit that referenced this issue Aug 23, 2024
@gurdeep330
feat: Add Zotero plugin and remove restrictions on number of articles…
de94c38 
… required to make recommendations using S2 (#53)

ref task VirtualPatientEngine/VPECompetitiveIntelligence#3 (comment)

* fix: #47

* feat: do not consider an article negative if it is already positive for a topic

* Feat/write recommended articles (#51)

* update data

* update data

* feat: add Zotero plugin

* chore: update README explaining the Zotero plugin

* chore: utils.py and reduce the number of articles to 200

---------

Co-authored-by: GitHub Action <action@github.com>

---------

Co-authored-by: AW Mulyadi <50047143+awmulyadi@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>

BREAKING CHANGE: Zotero + S2 updates
github-actions bot pushed a commit that referenced this issue Aug 23, 2024
@semantic-release-bot
chore(release): 2.5.0 [skip ci]
0d45664 
# [2.5.0](v2.4.0...v2.5.0) (2024-08-23)

### Features

* Add Zotero plugin and remove restrictions on number of articles required to make recommendations using S2 ([#53](#53)) ([de94c38](de94c38)), closes [/github.com/VirtualPatientEngine/VPECompetitiveIntelligence/issues/3#issue-2471909877](https://github.com//github.com/VirtualPatientEngine/VPECompetitiveIntelligence/issues/3/issues/issue-2471909877) [#47](#47) [#51](#51)
@github-actions GitHub Actions
Copy link
Contributor

🎉 This issue has been resolved in version 2.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Sep 5, 2024
@semantic-release-bot
chore(release): 3.1.0 [skip ci]
4d6f8bb 
# [3.1.0](v3.0.1...v3.1.0) (2024-09-05)

### Bug Fixes

* [#47](#47) ([7252026](7252026))
* changes on positive and negative articles, close [#47](#47) ([e46bfe3](e46bfe3))
* delete recommendation articles to avoid conflicts ([5446534](5446534))

### Features

* do not consider an article negative if it is already positive for a topic ([eef588c](eef588c))
* update README and recommendation settings ([b2924bb](b2924bb))
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gurdeep330 gurdeep330

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lilijap @gurdeep330 @awmulyadi