Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandoned mods #700

Merged
merged 8 commits into from
May 7, 2022
Merged

Abandoned mods #700

merged 8 commits into from
May 7, 2022

Conversation

cbc02009
Copy link
Contributor

  • The mod, firmware configuration or slicer profile is in the correct category
    folder. Printable mods go to printer_mods/, firmware configurations
    go to firmware_configurations/, slicer profiles go to slicer_profiles/.
    Create a subfolder with your name, and place the mods in a subfolder with
    a descriptive name within that folder, e.g.: /printer_mods/FHeilmann/flux_capacitor
  • Folders names MUST NOT contain spaces. If possible, make sure file names also
    do not contain any spaces.
  • For each mod, add a small README.md file to its folder with a short description
    of what the mod accomplishes. This readme can be used to add pictures, give assembly
    instructions or specify a bill of materials if the mod requires additional hardware.
  • The PR modifies the top-level README.md of the category folder adding the
    contribution to the table. Read the top part of the file for instructions on how
    to do this. Please preserve the alphabetical ordering while adding new rows. Make sure
    to fill out the compatibility matrix to indicate which versions of the Voron printer
    the submission is compatible with.
  • The mod/configuration/profile has been tested by the person submitting the mod
    and/or other Voron users. Make sure to add information about how the mod was tested below.
  • The mod is not merely a slight modification of an official Voron part, configuration
    or profile (i.e. an official Voron part with a few mm added or removed or a slicer profile
    which only modifies a few values). (When in doubt, contact one of the admins in the
    Voron discord before submitting the PR)
  • Submitted STLs are printable without support. (If the mod does not meet this criterion
    join the Voron discord and ask the other users for advice on how to modify the mod such
    that it does not require supports)
  • Submitted STL files are not corrupt. (This can be tested by opening the STL in PrusaSlicer
    and checking if mesh errors are reported.)
  • Submitted STL files are oriented and scaled properly for printing.
  • Submission includes a CAD file in the form of a .STEP or .SCAD file
  • Submitted firmware configs or slicer profiles contain no sensitive data (e.g. API keys).

Which mods/configurations/profiles are added by this PR?

How was it tested?

Any background context you want to provide?

Screenshots (if appropriate)

Further notes

  • Create a folder and readme for mods abandoned by the original author.
  • Move decontaminator and purge bucket mod to abandoned mods

fix order in readme.md
update readme.md for abandoned mods.
@cbc02009
Copy link
Contributor Author

cbc02009 commented Apr 20, 2022

Can't wait to see how many links this PR breaks.

EDIT: Only one. that's not as bad as I thought it would be.

Fix broken link to abandoned mod.
fix broken link to mod *for real this time*
Copy link
Contributor

@FHeilmann FHeilmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small typo, otherwise lgtm.

For a mod to be included in this list, the following conditions need to be met:
1. An issue or PR has been opened regarding the mod
2. An attempt was made to contact the original author either on github or discord
3. The autho has not responded for a period of at least two months
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@KiloQubit
Copy link
Contributor

Other than the typo mentioned above, LGTM as well.

@cbc02009
Copy link
Contributor Author

cbc02009 commented May 6, 2022

Typo fixed

@KiloQubit KiloQubit merged commit 339b14c into VoronDesign:master May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants