-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add single cell sample images module #10
Merged
roshankern
merged 16 commits into
WayScience:main
from
roshankern:add-single-cell-validation
Feb 10, 2023
Merged
Add single cell sample images module #10
roshankern
merged 16 commits into
WayScience:main
from
roshankern:add-single-cell-validation
Feb 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* finish download module changes * download notebook * rerun split data module * rerun download module * rerun train_model * rerun evaluation module * rerun interpretation module * combine datasets * combine datasets * split changes * update format * format update * format * finish split data * combine datasets, remove holdout * formatting * rerun pipelines * remove folded class * rerun pipeline * Update utils/download_utils.py Co-authored-by: Dave Bunten <ekgto445@gmail.com> * PR fixes * module docstrings Co-authored-by: Dave Bunten <ekgto445@gmail.com>
…enotypic_profiling_model into add-single-cell-validation
d33bs
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I left a few minor comments and suggestions through out but overall thought this looked good! Please don't hesitate to let me know if you have any questions.
Co-authored-by: Dave Bunten <ekgto445@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready for review!
This PR is the start of the single cell sample images module, which should provide a quick example of the model in action to new visitors. In correct_15_images.ipynb, we show 15 sample single cell images that the final model from 2.train_model correctly classifies.
Three single cell images from each of the 5 top performing classes (as determined by F1 score) are displayed and their paths are saved.
Note: Sample image files will be uploaded at the end of the PR, as including them here will make the review more difficult.
Sorry it is so large :(