Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new mitocheck data #4

Merged
merged 7 commits into from
Sep 12, 2022
Merged

Use new mitocheck data #4

merged 7 commits into from
Sep 12, 2022

Conversation

roshankern
Copy link
Member

@gwaybio This is ready for review!

I plan on restructuring the components of 3.ML_model into their own modules in the next PR. I think that would make the steps in this repository much more clear. The planned project structure is included in README.md. Let me know what you think.

As a side note, the data analysis will be completed in mitocheck_data instead of this repository.

@roshankern
Copy link
Member Author

Ended up restructuring 3.ML_model in this PR. Sorry about that 😬

@gwaybio
Copy link
Member

gwaybio commented Aug 25, 2022

p.s. - It might make sense to add results to the relevant READMEs

This will help folks that are new to the repository, plus it will really help when you go to write the results section :)

roshankern and others added 3 commits September 12, 2022 15:52
Co-authored-by: Gregory Way <gregory.way@gmail.com>
Co-authored-by: Gregory Way <gregory.way@gmail.com>
@roshankern
Copy link
Member Author

roshankern commented Sep 12, 2022

I added a results section to the train, evaluate, interpret readmes in 88b6697. In the case of images (confusion matrices, graphs, etc), readers are directed to the jupyter notebooks.

@roshankern roshankern merged commit 64cfc46 into WayScience:main Sep 12, 2022
@roshankern roshankern deleted the use-new-mitocheck-data branch September 12, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants