Add training/models of Zernike and AreaShape feature space only #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Merging this PR is required before I can update figure 3 (PR curves) to the balanced models. |
jenna-tomkinson
approved these changes
Oct 23, 2023
| "ignore", category=ConvergenceWarning, module="sklearn" | ||
| # train model on each combination of model type, feature type, and balance type | ||
| for balance in balanced_types: | ||
| if balance == "balanced": |
There was a problem hiding this comment.
I suggest adding a short code comment on why you are specifying the "balanced" model and setting the "unbalanced" model to None. I am assuming so that it doesn't run this model but I am not 100% sure.
There was a problem hiding this comment.
Sounds good! A short comment added in 7f2ca61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the following model training procedures:
I have also updated the evaluation procedures and added a summary visualization