Handle exact references when fixing non-defaultable locals #7357
+49
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some passes leave non-defaultable locals in an invalid state where not all the gets of the local are structurally dominated by sets. To fix this, the pass runner automatically calls `TypeUpdating::handleNonDefaultableLocals` to find the problematic locals and make them nullable. This function did not previously preserve exactness in the updated local types. Fix it and add a test.
kripken
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some passes leave non-defaultable locals in an invalid state where not
all the gets of the local are structurally dominated by sets. To fix
this, the pass runner automatically calls
TypeUpdating::handleNonDefaultableLocalsto find the problematiclocals and make them nullable. This function did not previously preserve
exactness in the updated local types. Fix it and add a test.