Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View rendering refactor #127

Closed
WillPower3309 opened this issue Mar 17, 2023 · 4 comments · Fixed by #367
Closed

View rendering refactor #127

WillPower3309 opened this issue Mar 17, 2023 · 4 comments · Fixed by #367
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@WillPower3309
Copy link
Owner

We should move all of our eye candy rendering to a window specific function. This would allow us to simplify our texture rendering function to have zero eyecandy and therefore be a little faster when rendering undecorated textures like titlebar text, Fullscreen windows, icons, toolbars etc.

Additionally, we can easily reuse the window's stencil for shadows and blur, since they'd be done in the same function. This would also save us a render pass for generating the stencil in the first place

We'd only need the call this rendering function in render_saved_view and render_view_toplevels. We'd have to remove the shadow logic from render_view, and we can change all other rendering calls to use simple no effect fragment shaders like in wlroots. This will also remove the need for deco_data in a lot of places (may need to have a rework of how we pass decoration data but that could be future follow up work). Damage tracking may become more complex.

@WillPower3309 WillPower3309 added the enhancement New feature or request label Mar 17, 2023
@WillPower3309
Copy link
Owner Author

This would allow us to potentially solve #25 more easily

This was referenced Mar 17, 2023
@WillPower3309 WillPower3309 self-assigned this Mar 18, 2023
@WillPower3309
Copy link
Owner Author

tex shader refactor in 1a10c61

@WillPower3309 WillPower3309 linked a pull request Mar 18, 2023 that will close this issue
@WillPower3309
Copy link
Owner Author

To elaborate my thoughts on deco_data, we could just completely remove deco_data, and instead add a struct to the container that holds the alpha / corner_radius / dim / shadows etc (these already exist in con, we'd just need a struct for them to be nested in). We could then just pass this struct into the decorated window rendering function.

@WillPower3309
Copy link
Owner Author

I'll be tackling this once kawase blur is merged, but prior to work on animations

@WillPower3309 WillPower3309 added this to the 1.0 milestone Apr 15, 2023
@WillPower3309 WillPower3309 linked a pull request Dec 26, 2024 that will close this issue
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant