Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rounded border corners #25

Closed
WillPower3309 opened this issue Oct 18, 2022 · 5 comments
Closed

Improve rounded border corners #25

WillPower3309 opened this issue Oct 18, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@WillPower3309
Copy link
Owner

WillPower3309 commented Oct 18, 2022

  • Description:
    There are some improvements that could be made in how we handle rendering rounded corners. Currently, rounded borders are done by drawing circles and removing the parts that are not along the corner we are currently rendering, and rounded titlebars will be blended with a window's rounded corners through its fragment shader, which is less than ideal for keeping things simple. I'll be working on making these things cleaner (and hopefully more performant), once we get an initial release out.
@WillPower3309 WillPower3309 added the enhancement New feature or request label Oct 18, 2022
@WillPower3309 WillPower3309 self-assigned this Oct 18, 2022
@WillPower3309
Copy link
Owner Author

still need to do this, but for now I've cleaned up the existing border shader from 54 to 36 lines

@ErikReider
Copy link
Collaborator

Oh! That looks promising!

@WillPower3309
Copy link
Owner Author

If we go the stencil route, this would likely fix #113 and #47 (and integrate well with #127)

@WillPower3309 WillPower3309 added this to the 1.0 milestone Apr 21, 2023
@WillPower3309
Copy link
Owner Author

Will be fixed once we use the scenefx border impl in wlrfx/scenefx#59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants