Add ProtoDefinitionHelper.FromDirectory #1263
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.7.x #1263 +/- ##
==========================================
+ Coverage 34.94% 39.15% +4.21%
==========================================
Files 201 202 +1
Lines 33266 34146 +880
==========================================
+ Hits 11624 13370 +1746
+ Misses 21087 20235 -852
+ Partials 555 541 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| var modifiedContent = !content.StartsWith(comment) ? $"{comment}\n{content}" : content; | ||
| var key = Path.GetFileNameWithoutExtension(filePath); | ||
|
|
||
| dictionary.Add(key, modifiedContent); |
There was a problem hiding this comment.
I'm curious why the filename isn't used as the key here. That would make resolving imports work without the comment.
The only change needed is to replace \ with / of the relative path.
There was a problem hiding this comment.
I'm curious why the filename isn't used as the key here.
The filename is used:var key = Path.GetFileNameWithoutExtension(filePath);
That would make resolving imports work without the comment.
The IProtoFileResolver is used in ProtobufJsonConverterFileSystem.cs which is required by protobuf-net to resolve additional files.
There was a problem hiding this comment.
From my debugging, it tries to resolve based on the import filename, which would match the key in the dictionary based on the relative file path, no?
No description provided.