Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click outside to dismiss mode switcher, inserter overlays #376

Closed
aduth opened this issue Apr 6, 2017 · 3 comments · Fixed by #582
Closed

Click outside to dismiss mode switcher, inserter overlays #376

aduth opened this issue Apr 6, 2017 · 3 comments · Fixed by #582
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone
May Week 1

Comments

@aduth
Copy link
Member

aduth commented Apr 6, 2017

Unsure if this will end up being satisfied by separate pull requests to address mode switcher and inserter separately, or common solution like a common Tooltip (Popover, Overlay) component.

Steps to reproduce:

  1. Click Inserter / Mode Switcher
  2. Click elsewhere on the page

Expected result:

Inserter / Mode Switcher toggled in step 1 is dismissed.

Actual result:

Inserter / Mode Switcher is not dismissed.
@aduth aduth added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Task Issues or PRs that have been broken down into an individual action to take Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Apr 6, 2017
@kopepasah
Copy link
Member

I agree that the switcher should disappear when a user performs an action (e.g. click) which takes focus away from the mode switcher.

This task is currently unassigned. Any objections to me diving in?

@youknowriad
Copy link
Contributor

Thanks for the offer to help. Feel free to take tackle this task 👍 (or any unassigned task)

@jasmussen jasmussen added this to the Prototype Parity milestone Apr 20, 2017
This was referenced Apr 26, 2017
Closed
Merged
@mtias mtias modified the milestones: May Week 1, Prototype Parity May 1, 2017
BE-Webdesign added a commit that referenced this issue May 2, 2017
@BE-Webdesign
Add click outside toggling to block switcher menu.
f56556f 
Along with #582 this will cover #376.  This adds the click outside
higher order component to the block switcher menu. So that clicks into
block content will close the menu while it is open.

**Testing instructions:**

Go to a heading or text block.  Open the block switcher menu in the top
left.  Click on that blocks text content outside of the menu.  Verify
that the menu closes.  Repeat this by clicking anywhere and verifying
that the switcher closes.  Verify that the switcher still works by
clicking on it.
@BE-Webdesign BE-Webdesign mentioned this issue May 2, 2017
Merged
@BE-Webdesign
Copy link
Contributor

#582, and #596, should close this out.

@nylen nylen closed this as completed in #582 May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
May Week 1
6 participants
@youknowriad @mtias @kopepasah @jasmussen @aduth @BE-Webdesign