Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix id attribute to match aria-owns attribute #15564

Merged
merged 2 commits into from
May 13, 2019
Merged

Fix id attribute to match aria-owns attribute #15564

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ff65d6
Fix id attribute to match aria-owns attribute
gchtr May 10, 2019
95424df
Use variables for ids used for ARIA attributes
gchtr May 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/url-input/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ class URLInput extends Component {
<Popover position="bottom" noArrow focusOnMount={ false }>
<div
className="editor-url-input__suggestions block-editor-url-input__suggestions"
id={ `editor-url-input-suggestions-${ instanceId }` }
id={ `block-editor-url-input-suggestions-${ instanceId }` }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we extract this id to a variable and use it in both places to prevent the same issue to happen again in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes total sense! I extracted the id into a variable suggestionsListboxId. 👍

ref={ this.autocompleteRef }
role="listbox"
>
Expand Down