-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks: Split frontend block styles into block.scss
files
#1590
Conversation
blocks/library/quote/block.scss
Outdated
& > .blocks-editable p { | ||
font-size: 24px; | ||
font-style: italic; | ||
&.blocks-quote-style-1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a note, we should clean these classes and make them proper modifiers.
blocks/library/quote/block.scss
Outdated
|
||
&.blocks-quote-style-2 { | ||
padding: 0 1em; | ||
& > .blocks-editable p { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make editable have a wp-blocks-editable
class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an error I should move this back to style.scss
and use > p
instead for frontend.
We also need to get the |
@mtias the |
Now the fixtures will hunt you... |
Nice work! I think we'll want to do a run on theme styles and polish all of these as a separate PR, but I think it would be great to get this in soon, especially since I did some polish work to many of the blocks in #1597. |
705c835
to
c1676e8
Compare
c1676e8
to
12efb79
Compare
Ok. I'll wait for the tests to pass and merge. :) |
This PR builds on top of #1418 and splits all the blocks' styles into two files
block.scss
for styles shared with the frontendstyle.scss
for styles only loaded in the editor.This should allow themes to support the gutenberg blocks without any change. The styles can be overriden by themes.
Testing instructions
Try the following blocks and ensure they're showing up properly on the frontend and the backend: