Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Video block on Android after Android X migration #16215

Merged
merged 2 commits into from
Jun 21, 2019
Merged

Re-enable Video block on Android after Android X migration #16215

merged 2 commits into from
Jun 21, 2019

Conversation

daniloercoli
Copy link
Contributor

@daniloercoli daniloercoli commented Jun 18, 2019 •
edited
Loading

This PR re-enables the Video block on Android.

Companion Mobile Gutenberg PR: wordpress-mobile/gutenberg-mobile#1150

Video block was disabled right before 1.7 version of gb-mobile, since there were issues with the Android implementation. #16149

@daniloercoli daniloercoli requested review from mkevins and marecar3 June 18, 2019 12:45
@daniloercoli daniloercoli added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jun 18, 2019
@daniloercoli daniloercoli mentioned this pull request Jun 18, 2019
Merged
mkevins
mkevins approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on WordPress-Android. Looks good, LGTM!

marecar3
marecar3 approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@daniloercoli daniloercoli merged commit 284bb17 into master Jun 21, 2019
@github-actions github-actions bot added this to the Gutenberg 6.0 milestone Jun 21, 2019
@youknowriad youknowriad deleted the rnmobile/enable-video-block-after-android-x-migration branch June 24, 2019 09:59
daniloercoli added a commit that referenced this pull request Jun 25, 2019
@daniloercoli
Revert "Re-enable Video block on Android after Android X migration (#…
5d62ed6 
…16215)"

This reverts commit 284bb17.
hypest pushed a commit that referenced this pull request Jun 28, 2019
@Tug @hypest
[RNMobile] Native mobile release v1.8.0 (#16344)
a53a38b 
* Revert "Re-enable Video block on Android after Android X migration (#16215)"

This reverts commit 284bb17.

* Don't forcefully cancel media upload on img/video unmount

Manually reverts d554ba3
marecar3 pushed a commit that referenced this pull request Jul 10, 2019
@daniloercoli @marecar3
Re-enable Video block on Android after Android X migration (#16215)
204d849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkevins mkevins mkevins approved these changes

@marecar3 marecar3 marecar3 approved these changes

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@daniloercoli @mkevins @marecar3