RichText: fix isSelected #17451
Merged
RichText: fix isSelected #17451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
daniloercoli,
etoledom,
jorgefilipecosta and
SergioEstevao
as code owners
|
@afercia Would be great to know if this fixes your issue. #17405 (comment) |
|
I tested this PR in addition with #17450 and the Yoast blocks seem to work properly. I also did a round of test for other blocks, everything seems to work as intended. I'm approving both PRs. It would be good to try to add an e2e test for this. |
youknowriad
approved these changes
Sep 16, 2019
youknowriad
added
[Feature] Rich Text
|
Yes, I agree. We specifically need an implementation RichText in a block where the block doesn't remove rich text selection state based on block selection. |
|
Thanks! Seems to work for me. Was waiting for my colleagues to double check :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to fix #17405. Looks like the
isSelectedprop should only be looked at if the current block is selected. Currently we assume that the block manages that, but in previous versions there was a check internally if the wrapping block is selected.How has this been tested?
Screenshots
Types of changes
Checklist: