Fix: Conditionaly apply Editor Skeleton html element styles #20245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
requested review from
ellatrix and
youknowriad
as code owners
youknowriad
reviewed
Feb 14, 2020
| @@ -17,6 +32,7 @@ function EditorSkeleton( { | |||
| publish, | |||
| className, | |||
| } ) { | |||
| useHTMLClass( 'block-editor-editor-skeleton-html-container' ); | |||
There was a problem hiding this comment.
Maybe more something like block-editor-editor-skeleton__html-container
youknowriad
approved these changes
Feb 14, 2020
jorgefilipecosta
force-pushed
the
fix/only-apply-html-styles-in-editor-sketelon-when-the-component-is-rendered
branch
from
6e19443 to
b9bbeeb
Compare
jorgefilipecosta
deleted the
fix/only-apply-html-styles-in-editor-sketelon-when-the-component-is-rendered
branch
jorgefilipecosta
added a commit
that referenced
this pull request
Feb 17, 2020
jorgefilipecosta
added a commit
that referenced
this pull request
Feb 17, 2020
jorgefilipecosta
removed
the
Backport to WP 6.8 Beta/RC
aduth
reviewed
Feb 27, 2020
| function useHTMLClass( className ) { | ||
| useEffect( () => { | ||
| const element = | ||
| document && document.querySelector( `html:not(.${ className }` ); |
This was referenced Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously editor skeleton applied styles to the HTML element unconditionally.
This PR makes sure the styles are only applied if the component is mounted.
Related: #20214 (comment)
It is important to get this in 5.4 because many blocks may have a bug where block editor styles are being enqueued without need and without this change we may be breaking the mobile experience for users with one of these blocks installed.
How has this been tested?
I verified the editor still works as expected on mobile.
I verified the styles for the new class are being loaded.