-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically generate required preset classes #25768
Merged
jorgefilipecosta
merged 2 commits into
master
from
add/automatically-generate-preset-classes
Oct 12, 2020
Merged
Automatically generate required preset classes #25768
jorgefilipecosta
merged 2 commits into
master
from
add/automatically-generate-preset-classes
Oct 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +19 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
7ed0d22
to
3692d18
Compare
82 tasks
getdave
reviewed
Oct 7, 2020
Co-authored-by: Dave Smith <getdavemail@gmail.com>
70b15f6
to
e8c9af4
Compare
aristath
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR automatically generates the preset classes (colors, gradients, and font size) without requiring the theme to explicitly include the classes.
Required because on #25711 we are allowing the user to edit the color palette and in that case, we need to generate the classes for these colors. These change also makes things easier for theme developers.
How has this been tested?
I verified that the global-styles-inline-css style element now contains the classes fro the colors, font-sizes, etc.
I added the following date to lib/experimental-default-theme.json
And I verified the color classes scoped to the button were correctly generated.