-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global Styles: Add button to reset color palette #26975
Merged
jorgefilipecosta
merged 2 commits into
master
from
add/global-styles-mechanism-to-reset-color-palette
Nov 17, 2020
Merged
Global Styles: Add button to reset color palette #26975
jorgefilipecosta
merged 2 commits into
master
from
add/global-styles-mechanism-to-reset-color-palette
Nov 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +54 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
Sync'd with the master branch. Without pulling latest commits from master I was getting an infinite-recursion PHP error and was unable to test this. |
aristath
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a button that allows users to reset user changes to the color palette, making the color palette have the theme or core defaults again.
How has this been tested?
I went to the edit site screen, global styles sidebar.
I made some changes to the color palette and I verified I could reset the changes using the reset button that is available.