Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reset button to Layout controls #30828

Merged
merged 1 commit into from
May 6, 2021

Conversation

Mamaduka
Copy link
Member

Adds reset button to the Layout controls, similar to other custom value controls.

Fixes #30614.

Screenshots

layout-reset-button

Types of changes

New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@Mamaduka Mamaduka added the [Type] Enhancement A suggestion for improvement. label Apr 14, 2021
@Mamaduka Mamaduka requested a review from ellatrix as a code owner April 14, 2021 09:41
@Mamaduka Mamaduka self-assigned this Apr 14, 2021
Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Mamaduka Mamaduka merged commit 2011119 into WordPress:trunk May 6, 2021
@Mamaduka Mamaduka deleted the add/layout-reset-button branch May 6, 2021 08:49
@github-actions github-actions bot added this to the Gutenberg 10.7 milestone May 6, 2021
@oandregal oandregal mentioned this pull request May 12, 2021
82 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout (width) controls do not have a reset button
2 participants