Generate classes and custom properties for global styles in the same way the post editor does #32766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
changed the title
oandregal
added
[Status] In Progress
youknowriad
added
the
Backport to WP 6.8 Beta/RC
|
Size Change: +32 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
ockham
reviewed
Jun 17, 2021
|
Looks like the linter is complaining -- try running Otherwise, it's looking pretty good already (based on unit test coverage -- haven't tested manually yet). We should certainly include this with 10.9, but maybe also with another 10.8 release? And how about WP 5.8? |
oandregal
force-pushed
the
update/class-generation-global-styles
branch
from
afc834f to
230f8b0
Compare
oandregal
changed the title
|
Ok. This is working fine in the site editor and front end. I've reduced the regexp to match lodash's kebabCase to the minimum and added tests that cover all the cases that I've found or were reported. |
jorgefilipecosta
approved these changes
Jun 17, 2021
goal is to replicate lodash's kebabCase behaviour
oandregal
force-pushed
the
update/class-generation-global-styles
branch
from
d069a55 to
1b72e7a
Compare
aristath
approved these changes
Jun 18, 2021
youknowriad
removed
the
Backport to WP 6.8 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 21, 2021
…way the post editor does (#32766)
youknowriad
pushed a commit
that referenced
this pull request
Jun 21, 2021
…way the post editor does (#32766)
Mamaduka
pushed a commit
that referenced
this pull request
Jun 23, 2021
…way the post editor does (#32766)
|
Cherry-picked to |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32347
We generate CSS classes for presets in a few places -post editor, site editor, server- and we need them to behave all the same. This PR explores porting lodash's
kebabCaseto the server. It's also applied to the names of the CSS Custom Properties for coherence.Background
This is the second take to fix #32347 We first tried to remove lodash's
kebabCasefunction in the client at #32352 but that caused some issues and had to revert the original PR at #32742How to test
In the front end:
settings.color.palette) in itstheme.jsonto contain edge cases (see this table and the tests at class-gutenberg-utils-test.php for inspiration). For example, set a slug toblack23white.global-styles-inline-cssstyle tag are generated properly as well as the CSS Custom Properties. Following the example above, you should find the--wp--preset--color--black-23-whitevar and the classeshas-black-23-white-color, etc.In the site editor:
settings.color.palette) in itstheme.jsonto contain edge cases (see this table and the tests at class-gutenberg-utils-test.php for inspiration). For example, set a slug toblack23white.--wp--preset--color--black-23-whitevar and the classeshas-black-23-white-color, etc.