Global Styles: Add unit tests for edit site editor utils #34401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeyip
added
[Feature] Full Site Editing
Global Styles
jeyip
requested review from
mattwiebe,
oandregal,
creativecoder,
Copons,
jorgefilipecosta and
Addison-Stavlo
jeyip
changed the title
|
The tests pass locally, so I wonder if you can rebase this PR from latest |
jeyip
force-pushed
the
add/edit-site-editor-utils-tests
branch
from
e554914 to
0594630
Compare
|
The failing CI checks appear to be an issue with |
jeyip
force-pushed
the
add/edit-site-editor-utils-tests
branch
from
0594630 to
7817e48
Compare
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests to global styles utils in
packages/edit-site/src/components/editor/utils.jsfor:getPresetVariable()getValueFromVariable()Note:
This PR does not include tests for the
useSetting()hook, which lives in the same utils file.How has this been tested?
Run
npm run test-unit packages/edit-site/src/components/editor/test/utils.jsin a terminal from within the Gutenberg repoScreenshots
Before
After
Types of changes
Adds Tests
Checklist:
*.native.jsfiles for terms that need renaming or removal).