Add template areas to template inspector #35239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Feature] Template Editing Mode
kevin940726
requested review from
adamziel,
getdave,
noisysocks,
talldan,
jameskoster,
tellthemachines and
anton-vlasenko
|
Size Change: +297 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
kevin940726
commented
Sep 30, 2021
| @@ -36,9 +37,11 @@ export default function TemplateCard() { | |||
| <Icon className="edit-site-template-card__icon" icon={ icon } /> | |||
| <div className="edit-site-template-card__content"> | |||
| <h2 className="edit-site-template-card__title">{ title }</h2> | |||
| <span className="edit-site-template-card__description"> | |||
| <div className="edit-site-template-card__description"> | |||
There was a problem hiding this comment.
Any reason why this wasn't a <p>?
There was a problem hiding this comment.
I'd expect it to be a <p> given description is escaped and so can't contain markup.
There was a problem hiding this comment.
The description in all the blocks are all using <span> for some reasons. That's why I'm wondering if there are something we haven't thought of?
There was a problem hiding this comment.
Weird! No reason it should hold up this PR.
noisysocks
approved these changes
Oct 6, 2021
noisysocks
reviewed
Oct 6, 2021
| ); | ||
| } | ||
|
|
||
| export default function TemplateAreas() { |
There was a problem hiding this comment.
I see a similar TemplateAreas component in #35202. Can we re-use?
There was a problem hiding this comment.
Probably not a good idea, since that one is using <MenuItem> and this is using plain <Button>. I've already moved some common parts to a selector, the rests are mostly UI. We can create a UI component for them if there's a need.
There was a problem hiding this comment.
Better to abstract too late than too early!
jameskoster
approved these changes
Oct 6, 2021
kevin940726
force-pushed
the
add/template-areas-in-template-inspector
branch
from
5368adc to
cd36f7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses a part of #29147.
Add Template Areas to the template inspector.
How has this been tested?
tt1-blocksthemeScreenshots
Kapture.2021-09-30.at.14.10.32.mp4
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).