Widgets: Optimize useSelect calls #35256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
Mamaduka
added
[Type] Code Quality
|
Size Change: -28 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
kevin940726
requested changes
Sep 30, 2021
packages/customize-widgets/src/components/keyboard-shortcut-help-modal/dynamic-shortcut.js
Outdated
Show resolved
Hide resolved
packages/edit-widgets/src/components/keyboard-shortcut-help-modal/dynamic-shortcut.js
Outdated
Show resolved
Hide resolved
…lp-modal/dynamic-shortcut.js Co-authored-by: Kai Hao <kevin830726@gmail.com>
…dal/dynamic-shortcut.js Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
|
Thanks, @kevin940726, for catching those. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds missing dependency arrays to
useSelectcalls to memorize selector callbacks in the Widgets-related packages.How has this been tested?
Make sure new Widget screens work correctly.
Types of changes
Code Quality/Performance
Checklist:
*.native.jsfiles for terms that need renaming or removal).