Lower the specificity of font size CSS Custom Properties in the editor #37526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Bug
|
Size Change: -5 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Dec 20, 2021
ntsekouras
approved these changes
Dec 20, 2021
There was a problem hiding this comment.
Thanks @oandregal ! I tested and works as expected.
Failing tests seem to be unrelated and in fact some of them are the same in this PR. Could these be intermittent failures in trunk? 🤔
Yeah, and it works fine in the frontend. This actually mimics what happens in the frontend's styles: they have 010 specificity, which is the same as coming from the global stylesheet but because GS loads later it wins. |
oandregal
force-pushed
the
fix/font-size-classes
branch
from
4c1c0ca to
8b6f501
Compare
aristath
approved these changes
Dec 21, 2021
noisysocks
removed
the
Backport to WP 6.8 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37381 (comment)
How to test
theme.json. For example, TwentyTwentyTwo.normalfont size to the list of font sizes:stylessection of thetheme.json:The expected result is that the default font size for the paragraph is
23pxand not16px.