Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Page title for pages created inline within in Nav block #41063

Merged
merged 12 commits into from
May 20, 2022
Merged

Fix broken Page title for pages created inline within in Nav block #41063

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
43fb468
Decode entities not escape
getdave May 13, 2022
6f02e82
Escape at point of output
getdave May 13, 2022
85ccb91
Move decoding to where it is actually required
getdave May 18, 2022
559f139
Remove title escaping test. Now done at point of output.
getdave May 18, 2022
bdcd9e8
Consume the raw value for editing
getdave May 19, 2022
f57289d
Remove entity decoding since consuming raw
getdave May 19, 2022
83a05dc
Revert. Make interoperable with existing implementation.
getdave May 19, 2022
06fd7ba
Add additional context to usages
getdave May 19, 2022
906a717
Explain usage of decode entities
getdave May 19, 2022
ee75bd5
Tweak comments
getdave May 19, 2022
d29de3e
Ensure aria label is also available on Draft Pages
getdave May 20, 2022
8703fa2
Add test coverage for HTML chars on Draft Pages
getdave May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ensure aria label is also available on Draft Pages
  • Loading branch information
@getdave
getdave committed May 20, 2022
commit d29de3eb53f8bd78da4efd6562c961f12fccbbc1
6 changes: 5 additions & 1 deletion packages/block-library/src/navigation-link/edit.js
View file
Original file line number Diff line number Diff line change
@@ -815,7 +815,11 @@ export default function NavigationLinkEdit( {
text={ tooltipText }
>
<>
<span>
<span
aria-label={ __(
'Navigation link text'
) }
>
{
// Some attributes are stored in an escaped form. It's a legacy issue.
// Ideally they would be stored in a raw, unescaped form.