CustomSelectControl: Use styles from SelectControl #42460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +34 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
mirka
commented
Jul 15, 2022
Comment on lines
-44
to
-49
| right: $grid-unit-10; | ||
| right: $grid-unit-05; | ||
| top: 0; | ||
|
|
||
| &:not(.is-next-36px-default-size) { | ||
| right: $grid-unit-05; | ||
| } |
There was a problem hiding this comment.
I'm going to remove this conditional for now — you might notice that the spacing after the chevronDown is slightly different from the one in trunk, when __next36pxDefaultSize=true. This responsive spacing will be added back in a cleaner way after #42378 lands.
ciampo
approved these changes
Jul 15, 2022
There was a problem hiding this comment.
Code changes LGTM 🚀
The only differences that I could notice compare to trunk are:
- the font size used to be
11px(I believed caused by adding theisSmallprop to theButtoncomponent), while it's not13px - the chevron icon to the right is rendered slightly closer to the right border, compared to how it used to be (although that will be likely fixed in a follow-up PR, like explained in this PR's description and in https://github.com/WordPress/gutenberg/pull/42460/files#r921971827)
Kapture.2022-07-15.at.14.12.27.mp4
I'm inclined to approve this PR, and consider the increase in font size an improvement towards consistency across similar select components — WDYT ?
Right, I consider the font size to be a bug fix. It's a side effect of the |
mirka
force-pushed
the
custom-select-control-styles
branch
from
9c1afa5 to
cfc1455
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reuse the same styling components used in SelectControl for a more consistent design. This replaces the hacky
Button-based styling that was being used.Why?
This eliminates a bunch of styling inconsistencies between SelectControl and CustomSelectControl, including:
Plus, we get all the size variants for free.
How?
To limit the scope of this PR, the following will be done as follow-up tasks:
chevronDownicon to the standardsuffixprop (after InputControl: Add padding wrapper for prefix/suffix #42378 lands).width: 100%overrides in the codebase.__nextConstrainedWidthflag, add an official deprecation warning.Testing Instructions
npm run storybook:devand see the CustomSelectControl story.__nextUnconstrainedWidth=false, the width behavior should be the same as in trunk. Basically, the width is 130px by default but can grow if the selected option label is longer than that.__nextUnconstrainedWidth=true, each size variant should look the same as the ones for SelectControl.Screenshots or screencast
CleanShot.2022-07-15.at.17.52.38.mp4