Update/floating UI version #43206
Merged
Update/floating UI version #43206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Code Quality
|
Size Change: +363 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ntsekouras
force-pushed
the
update/floating-ui-version
branch
from
6693f8d to
a8293f5
Compare
ciampo
approved these changes
Aug 16, 2022
| @@ -231,11 +231,11 @@ const Popover = ( | |||
| ? undefined | |||
| : size( { | |||
| apply( sizeProps ) { | |||
| const { height } = sizeProps; | |||
There was a problem hiding this comment.
Well spotted!
For reference, this breaking change was introduced in the 0.7.0 version
ciampo
reviewed
Aug 16, 2022
ntsekouras
force-pushed
the
update/floating-ui-version
branch
from
5b26d15 to
d4d3421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR just updates the
floating-uilibrary to the latest version (see floating-ui/floating-ui#1796)Testing Instructions
Everything with Popovers should work as before.