Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the Custom Color button from looking like a pancake #4392

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Stop the Custom Color button from looking like a pancake #4392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions blocks/color-palette/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ $color-palette-circle-spacing: 14px;
&:hover {
transform: scale( 1.2 );
}

// Ensure that the <div> that <Dropdown> wraps our toggle button with is full height
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, considering the div was added as intentionally expected to be unstyled, adding styles here seems to defeat its purpose to an extent. See #3958.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, fair.

From #3958 (comment):

An alternative approach I considered was to account for / ignore padding in the popover positioning, but this would be non-trivial to implement because the popover component allows for custom behavior to define anchor parent bounds.

Is this something we should re-consider?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's review this approach after the release. It doesn't seem necessary for this case either, so adding redundant divs should be avoided.

& > div {
height: 100%;
width: 100%;
}
}

.blocks-color-palette__item {
Expand Down