Convert FontSizePicker to TypeScript #44449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Code Quality
|
Size Change: +39 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Sep 26, 2022
ciampo
reviewed
Sep 27, 2022
| }, | ||
| }, | ||
| }, | ||
| argTypes: {}, |
There was a problem hiding this comment.
We usually keep components controlled in Storybook
Suggested change
| argTypes: {}, | |
| argTypes: { | |
| value: { control: { type: null } }, | |
| }, |
There was a problem hiding this comment.
Ah yeah that makes sense 👍
ciampo
reviewed
Sep 27, 2022
Comment on lines
20
to
23
| parameters: { | ||
| controls: { expanded: true }, | ||
| docs: { source: { state: 'open' } }, | ||
| }, |
There was a problem hiding this comment.
Let's leverage Storybook's actions! We can do so by flagging on* callbacks as actions, and passing through the onChange prop in FontSizePickerWithState:
diff --git a/packages/components/src/font-size-picker/stories/index.tsx b/packages/components/src/font-size-picker/stories/index.tsx
index 4937214fca..51bc3c3831 100644
--- a/packages/components/src/font-size-picker/stories/index.tsx
+++ b/packages/components/src/font-size-picker/stories/index.tsx
@@ -16,8 +16,11 @@ import FontSizePicker from '../';
const meta: ComponentMeta< typeof FontSizePicker > = {
title: 'Components/FontSizePicker',
component: FontSizePicker,
argTypes: {},
parameters: {
+ actions: { argTypesRegex: '^on.*' },
controls: { expanded: true },
docs: { source: { state: 'open' } },
},
@@ -26,6 +29,7 @@ export default meta;
const FontSizePickerWithState: ComponentStory< typeof FontSizePicker > = ( {
value,
+ onChange,
...props
} ) => {
const [ fontSize, setFontSize ] = useState( value );
@@ -33,7 +37,10 @@ const FontSizePickerWithState: ComponentStory< typeof FontSizePicker > = ( {
<FontSizePicker
{ ...props }
value={ fontSize }
- onChange={ setFontSize }
+ onChange={ ( v ) => {
+ setFontSize( v );
+ onChange?.( v );
+ } }
/>
);
};There was a problem hiding this comment.
You are a fountain of knowledge, Marco!
ciampo
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
LGTM! We can merge this PR once the couple of leftover comments are addressed 🚀
(I also tested the component with the experimental viz reg that we've recently introduced)
Oh wow that's cool. |
It really is — props to Lena for working on it! Hopefully it will help us with components like Popover, Button, FontSizePicker and more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #35744
Converts
FontSizePickerto TypeScript so as to add types toFontSizePicker.Why?
One step closer to all of
@wordpress/componentsbeing in TypeScript. Also I'm about to make some changes toFontSizePickerand some type checking might be helpful.How?
https://github.com/WordPress/gutenberg/blob/trunk/packages/components/CONTRIBUTING.md#refactoring-a-component-to-typescript
Testing Instructions
Check that tests pass and the storybook for
FontSizePickerstill functions correctly.