Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to specific sections of Redux docs #4453

Merged
merged 1 commit into from
Jan 17, 2018

Conversation

Shelob9
Copy link
Contributor

@Shelob9 Shelob9 commented Jan 13, 2018

#4452

Description

This adds links to Redux documentation for concepts mentioned in the article that are native to Redux.

How Has This Been Tested?

Using the preview in Github.

Checklist:

  • [x ] My code is tested.
  • [x ] My code follows the WordPress code style.
  • [x ] My code follows has proper inline documentation.

@aduth
Copy link
Member

aduth commented Jan 16, 2018

cc @youknowriad : Was it your intention to avoid the abstraction having strict overlap with Redux?

@aduth aduth requested a review from youknowriad January 16, 2018 21:29
@aduth aduth added the [Type] Developer Documentation Documentation for developers label Jan 16, 2018
@youknowriad
Copy link
Contributor

Was it your intention to avoid the abstraction having strict overlap with Redux?

This was my intention for the API exposing the data. Since we're going with selectors, I don't mind adding links to the Redux docs to clarify some concepts (reducer, selectors,...)

@youknowriad youknowriad merged commit 8d3a673 into WordPress:master Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants