Lodash: Refactor away from _.pick()
#45946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
|
|
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
tyxla
force-pushed
the
remove/lodash-pick
branch
from
379206a to
fa564ce
Compare
tyxla
removed
the
[Status] Blocked
tyxla
requested review from
swissspidy,
ntsekouras,
sgomes,
jsnajdr,
flootr,
aristath,
brookewp,
chad1008 and
fabiankaegy
|
|
tyxla
force-pushed
the
remove/lodash-pick
branch
from
fa564ce to
1886f89
Compare
sgomes
approved these changes
Nov 24, 2022
|
Seems like we introduced a regression with this one, it's being fixed in #49431. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.pick()completely and deprecates the package. There is just a single usage and conversion is pretty straightforward.This PR
iswas blocked by a few PRs:_.pick()in block library #45940_.pick()in block editor #45942getMergedGlobalStyles()away from_.pick()#45943_.pick()#45944_.pick()#45945It's expected that the static type and linting check fails before they have landed.I've rebased the PR now and it is ready for review.
Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're refactoring the logic of the function to greatly simplify it from:
Before: Filter 2 objects by certain known keys, compare the values, and return true if they are the same, false otherwise
After: Return true if the value of every known key for object 1 is the same as for object 2, false otherwise.
This allows us to not only remove 2
_.pick()instances, but also one of_.isEqual().Testing Instructions