Navigation Link: restore tooltip #54263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookewp
added
[Type] Bug
|
Size Change: -177 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Sep 8, 2023
|
Seems good to me at a glance! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While looking at our internal usage of our Tooltip component, I noticed that the tooltip isn't showing in the Navigation block. The tooltip was added in #35139 for missing URLs, and another was added for invalid links in #31716. In the latter PR, a span containing the tooltip text and custom CSS to hide it was added, in addition to the Tooltip component.
Why?
From a glance, it appears that the tooltip is intended to show. It's been a while since it's been worked on, but perhaps @jasmussen and @vcanales can confirm whether the tooltip should be visible.
How?
If we do want to show a tooltip, we can remove the span and custom class and display the tooltip through the component. I also believe the position should be the default,
bottom, so the toolbar does not hide it.Testing Instructions
For missing URLs:
For invalid links:
Screenshots or screencast
Position set to
top:Position set to
bottom(default):