Unify the PostSchedule component between site and post editors #56196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
|
Size Change: -254 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
update/unify-schedule-post-component
branch
from
8b0c4b6 to
c4d953b
Compare
youknowriad
commented
Nov 16, 2023
|
|
||
| .editor-post-schedule__panel-dropdown { | ||
| width: 70%; | ||
| } |
There was a problem hiding this comment.
Some of the styles above are duplicated between these "panels". Since this is the second panel I'm adding, I think it's fine, but as a direct follow-up for this PR, I'll try to see if we can use a common UI component and share it across the panels.
Both post and site editor approaches are not satisfying for me:
- Site editor reuses classnames, we should always reuse components and not classnames
- Post editor duplicates styles.
There was a problem hiding this comment.
The follow-up is ready here #56238
How about adding props like |
|
@t-hamano I don't really see the site and post editors as different editors, ultimately they should merge. So I prefer that we make a decision and go with one formatting or the other |
|
@youknowriad I see. Personally, I prefer displaying the full date. The reason for this is that the full date is used in the admin post list and post editor, and I think users are familiar with that format. What do you think? |
|
I went with the other format because it was shorter and easier to read but I'm not very opinionated and would go with whatever. Curious what designers think |
|
For unification purposes lets go with full date for now and we can revisit later if we want. I came across a separate issue where publish date on drafts is set to 2 months ago until you refresh the page. I'm assuming this is current behaviour so can leave fix out of this work. 
|
|
ok, I'm fine with that, I'll update the PR :) |
youknowriad
force-pushed
the
update/unify-schedule-post-component
branch
from
b5df462 to
df2fe7b
Compare
|
I've restored the full date format and it's now used in both editors. This should be ready for a final review. |
|
I'm not sure the publish date should be forced to stay in one line and truncated with That maybe made sense with the shorter format previously used in the Site editor, when the date was something like: Now that the date is the full date, a portion of the publish date/time is invisible to users. Partially hiding such an important information doesn't seem ideal. Screenshot:
Please also consider that month names can get way longer when translated to some languages. There is no way to predict how much space the publish date/time string will need. |
|
@afercia sure, happy to do that, what do you think @SaxonF @jameskoster |
|
Thanks Riad. I creatd #56262 to keep track of it. |
|
Agree it's important to see full date, especially for scheduled posts. If this is how it worked previously in the post editor would it be easiest to restore that behavior? Multi-line Buttons aren't ideal, but that's something to address separately when we get around to updating the Summary panel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
Follow-up to #56000
closes #55111
What?
Now that we're using the EditorProvider in the site editor, we should be able to reuse the exact same component the post editor uses to edit post properties and attributes. In this PR, I'm unifying the "PostSchedule" or "PostPublishDate" component between both.
I'm using the best of both here:
Testing Instructions
1- Ensure that the changing the page publish date still looks and works well in both post and site editors.