DataViews: Update template parts view #57952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Experimental
ntsekouras
requested review from
mcsf,
youknowriad,
oandregal and
jorgefilipecosta
|
Size Change: -257 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jan 18, 2024
youknowriad
reviewed
Jan 18, 2024
packages/edit-site/src/components/page-template-parts/dataviews-template-parts.js
Outdated
Show resolved
Hide resolved
ntsekouras
force-pushed
the
add/template-part-dataviews
branch
from
c254161 to
1c2ddaa
Compare
|
There's an issue with the details: it redirects to the wrong postType. Gravacao.do.ecra.2024-01-19.as.10.27.30.movAdditionally, in implementing Template Parts, the current approach to naming shows as something to improve. A simple tweak could be to update the copy of the button to say "Add new". 
Unrelated to this PR, but I've noticed the new dataviews-powered Patterns screen doesn't use the "Add new" button in the content area, it still uses the 
|
oandregal
reviewed
Jan 19, 2024
packages/edit-site/src/components/page-templates-template-parts/index.js
Outdated
Show resolved
Hide resolved
oandregal
reviewed
Jan 19, 2024
| }, | ||
| }; | ||
| if ( item.type === TEMPLATE_PART_POST_TYPE ) { | ||
| linkProps.state = { |
There was a problem hiding this comment.
I haven't seen this in use, what is it for? I presume it's for setting the path in case the users click the browser's back button after they've gone to the editor by clicking the title. Is this correct? If so, why templates don't need this?
oandregal
reviewed
Jan 19, 2024
| isTemplateRemovable( template ) && template.is_custom, | ||
| isEligible: ( template ) => { | ||
| if ( | ||
| ! isTemplateRemovable( template ) || |
There was a problem hiding this comment.
I found this logic difficult to grok. What would you think of rewriting it by stating the conditions for each post type independently? Something along these lines could work:
if (
template.type === TEMPLATE_PART_POST_TYPE &&
isTemplateRemovable( template )
) {
return true;
}
if (
template.type === TEMPLATE_POST_TYPE &&
isTemplateRemovable( template) &&
template.is_custom
) {
return true;
}
return false;
oandregal
reviewed
Jan 19, 2024
| ); | ||
| } else { | ||
| successMessage = __( 'Templates deleted.' ); | ||
| successMessage = isTemplate | ||
| ? __( 'Templates deleted.' ) |
There was a problem hiding this comment.
I've mentioned this elsewhere, but I think we could do with using a generic language. For example, Items deleted..
The users already have the context of what they are – they know whether they are working with templates or template parts, don't need reminding. And this code would be a lot simpler.
I don't have a strong opposition to doing it this way, and it works fine. I just want to share an alternative that I find clearer for everyone.
There was a problem hiding this comment.
I agree with this and would need less code :). Le't handle this in a follow up though because others might chip in about the clarity of the messages and wouldn't want to block this PR for that.
oandregal
reviewed
Jan 19, 2024
packages/edit-site/src/components/page-templates-template-parts/index.js
Outdated
Show resolved
Hide resolved
ntsekouras
force-pushed
the
add/template-part-dataviews
branch
3 times, most recently
from
e7c4350 to
ce2a55b
Compare
ntsekouras
force-pushed
the
add/template-part-dataviews
branch
from
ce2a55b to
3cd08ff
Compare
oandregal
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #55083
This PR updates the template parts list in site editor to use DataViews. Since templates and template parts have almost identical handling I've created a thin DataViews wrapper for both and most changes are checks about the type to use some different labels.
Testing Instructions
Screenshots or screencast
Screen.Recording.2024-01-18.at.12.09.35.PM.mov