[Mobile] - BottomSheetSelectControl - Add empty fallback option #60333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…selected option couldn't be found
geriux
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.73 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
twstokes
approved these changes
Apr 2, 2024
geriux
removed
the
Mobile App - Automation
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
…Press#60333) * Mobile - BottomSheetSelectControl - Add empty fallback option if the selected option couldn't be found * Update Changelog
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
This PR adds an empty option fallback if the selected value can't be found in the
itemsarray.Why?
There might be cases where the selected item is no longer present in the options due to cache or settings changing from the server. If the selected option is not present
selectedOptionreturnsundefinedcausing this component to crash when trying to access thelabelvalue.How?
By adding an empty state
EMPTY_OPTIONas a fallback whenselectedOptionis undefined.Testing Instructions
Smoke test this component works as expected in the following cases:
Buttons block
Image block
ImageSizeOptions.mov