Raw Handling - msListIgnore - Check attributes are valid #60375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e cases where invalid attributes are present
geriux
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +7 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
|
Should we add that snippet to the integration tests? Where does that "invalid-style" come from? |
ellatrix
approved these changes
Apr 2, 2024
Good idea! I'll add that!
Unfortunately, I couldn't find a real case for the reproduction steps so I added |
|
I mean, if it's not real HTML that comes from MS Word, then no need to add an integration test. I thought their markup changes and that is causing a failure. |
twstokes
approved these changes
Apr 2, 2024
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
…e cases where invalid attributes are present (WordPress#60375)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes some edge cases where there are invalid attributes in the
styleattribute. Ideally, there should only be valid values but it looks like this is not the case with MS Word.Why?
There are some crash reports in the mobile editor related to this code.
How?
By checking both
keyandvalueare notundefined.Testing Instructions
Paste the following snippet into the Web or Mobile editor:
Testing Instructions for Keyboard
N/A, does not apply.
Screenshots or screencast