Update Heading icon #9159
Merged
Update Heading icon #9159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refines the recent heading icon change in #9152 (comment), per feedback. Although it is H for Heading, internationally that first letter is not quite as ubiquitous, whereas T fares a bit better. By changing from an H we are also avoiding the very same issue that we sought to address by bringing back the Paragraph icon, namely that there are going to be icons (for heading levels) right next to the switcher, and if they look too alike that might cause confusion.
mtias
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refines the recent heading icon change in #9152 (comment), per feedback.
Although it is H for Heading, internationally that first letter is not quite as ubiquitous, whereas T fares a bit better. By changing from an H we are also avoiding the very same issue that we sought to address by bringing back the Paragraph icon, namely that there are going to be icons (for heading levels) right next to the switcher, and if they look too alike that might cause confusion.
Subheading was also updated to the same, still with the same pattern of a smallcap italicized, to show the relationship between heading and subheading.
Note that if a better icon idea comes around, we can always update this again, but for now let's make this the baseline to beat.