Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parisienne] Remove non-gutenberg HTML in block template files #19

Merged
merged 3 commits into from
Feb 24, 2020

Conversation

kjellr
Copy link
Collaborator

@kjellr kjellr commented Feb 12, 2020

Following the lead of #14 and #15 (and #16). The <header>, <main>, and <footer> elements inside of block-template files render as broken classic blocks in the experimental Site Editor. This PR changes those to use group blocks instead, which improves a user's ability to use that screen.

This PR also removes an unused function at the end of functions.php, and tidies up some spacing in there too.

@kjellr kjellr added the enhancement New feature or request label Feb 12, 2020
@kjellr kjellr requested a review from jffng February 12, 2020 19:54
@kjellr kjellr self-assigned this Feb 12, 2020
Since it wasn't there previously.
Copy link
Collaborator

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up, @kjellr.

@jffng jffng merged commit b3b3722 into master Feb 24, 2020
@kjellr kjellr deleted the try/remove-non-gutenberg-html-parisienne branch February 24, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants